Log file#588
Conversation
intjftw
left a comment
intjftw
left a comment
There was a problem hiding this comment.
Currently the log appears to me like this:
2023-01-09 14:30:28.856078000 [INFO] [cppparser] parse started!
2023-01-09 14:30:28.856732000 [INFO] (2/2) Parsing /home/efekane/repos/tinyxml2/tinyxml2.cpp
2023-01-09 14:30:28.856742000 [INFO] (1/2) Parsing /home/efekane/repos/tinyxml2/xmltest.cpp
2023-01-09 14:30:29.051323000 [INFO] Indexer started! Mode: CREATE
I think the fraction of seconds should not appear, it's more annoying than useful. This also applies to saving to file.
The other issue is that the exact time stamp appears in the "core" CC log files, while it does not appear in the search plugins log files. Otherwise the logging works well for both the parser and the webserver.
|
One other thing I forgot in the review: the readme and the help text in both the parser and the webserver should be complemented with usage guide for logging options. |
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Great work! 👍
A couple of minor changes should be made before merging.
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Thanks for the corrections!
3 participants
Logging to file option added.
In this version the java plugins log to their own files, while the C++ parts of the code log to a common file.